Feat introduced icp nonces for context contract #1031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ment, added tracking cycle spending in proxy tests
miraclx
reviewed
Dec 20, 2024
miraclx
reviewed
Dec 20, 2024
miraclx
reviewed
Dec 20, 2024
miraclx
approved these changes
Dec 20, 2024
miraclx
reviewed
Dec 20, 2024
Comment on lines
+141
to
+145
| configs | ||
| .contexts | ||
| .get(&context_id) | ||
| .and_then(|context| context.member_nonces.get(&member_id)) | ||
| .copied() |
There was a problem hiding this comment.
for consistency, we should probably panic if the context does not exist
same as we have it above
There was a problem hiding this comment.
but should we be panicking in ICP at all? how do they handle that? since the state is in-memory, do we lose data?
|
And.. migrations though there's no active deployment, so I guess we can get away with it |
miraclx
approved these changes
Dec 23, 2024
|
|
||
| // Execute the transfer with proper type annotations | ||
| let transfer_result: Result<(Result<u64, TransferError>,), _> = | ||
| ic_cdk::call(ledger_id, "transfer", (transfer_args,)).await; |
There was a problem hiding this comment.
icrc2's transfer_from? or does this work too
…ontract principal, removed static IDs of canisters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced nonce logic for mutate requests in icp context contract.
Optimized context contract for less spending.
Optimized proxy contract for cross-contract calls that include deposit